Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fatals and panics + fix loggings in init container #666

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Aug 27, 2024

Description

As title

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq added type/enhancement New feature or request type/fix Fixes something labels Aug 27, 2024
@nddq nddq self-assigned this Aug 27, 2024
@nddq nddq requested a review from a team as a code owner August 27, 2024 01:09
Copy link

There was an error handling pipeline event 181ea23e-eecc-4415-bdbc-92345c9319de.

@nddq nddq requested a review from timraymond August 27, 2024 14:32
@nddq nddq enabled auto-merge August 27, 2024 18:11
@timraymond
Copy link
Member

Looks great!

@nddq nddq added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 6d9050c Aug 27, 2024
24 checks passed
@nddq nddq deleted the nddq/fix/init branch August 27, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants